-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motion events emulation & multitouch gestures for touch events broken as of 2.0.22 on certain devices (X11) #5652
Comments
koreader/koreader#9091 |
Can you check that commit and see if that's the problem? It doesn't look like that would have the effect you're describing, offhand. |
Can you use git bisect to identify the breaking change? |
Offending commit is: 5ff4243 Setting |
Why does auto capture affect touch events? |
That commit caused way too many issues |
Touch handling on X11 with auto capture enabled is broken in general, it's not just gestures or mouse emulation. SDL sends an FINGERUP event right after FINGERDOWN (sometimes there's a single FINGERMOTION in between in you move your finger fast), so the touches end as soon as they start. |
@icculus, can you look into this? |
For what it's worth, here is a reproduction case for the single touch mouse motion emulation (with |
Yeah, I'll take a look. |
I can reproduce this here, I'm investigating. |
Fixed, thanks! |
As of upgrading to 2.0.22 on certain devices on X11, the emulation of motion events for touch devices is broken. Specifically I'm testing on the Pinephone on X11. What I've observed is that
SDL_MOUSEBUTTONUP
andSDL_MOUSEBUTTONDOWN
are properly reported, howeverSDL_MOUSEMOTION
events are not reported. Additionally gesture events (SDL_MULTIGESTURE
) are not reported. Downgrading to 2.0.20 fixes these issues andSDL_MULTIGESTURE
andSDL_MOUSEMOTION
are then properly reported.I've also noticed that setting the hint
SDL_TOUCH_MOUSE_EVENTS
to0
restores the functionality ofSDL_MULTIGESTURE
events (but doesn't effect motion events..).If I had to guess the root cause of this issue is: 8f8b14c .. however I haven't tested beyond just downgrading to 2.0.20 and seeing things work.
I'm testing on X11/Alpine Linux edge (postmarketOS) on a Pinephone (aarch64). Two example applications packaged to test with are
mepo
andrue
which both use touch events (and you can observe differences in application functionality between 2.0.22 and 2.0.20).The text was updated successfully, but these errors were encountered: