Experimental fix for crashing on uwp/xbox

[joepogo]

Games that use any type of threading on mame crashes retroarch back to dash on Xbox consoles.

This fix should allow for all mame games to now work correctly with no crashing.

[sonninnos]

Please put them inside proper #ifdefs, since this will affect every platform.

[joepogo]

Thanks @sonninnos ! One problem, I'm not sure how to do it exactly and where to put it.

I'm just following the code from the issue ticket. Is it possible for someone to show me what I need to add?

[grant2258]

@sonninnos I don't see how a define would be possible as the xbox uses the windows builds afaik.

[joepogo]

Yea, Xbox is on the uwp build. It's most likely crashing for anyone using uwp, is there a define for uwp?

[joepogo]

Hey @grant2258 is it possible to add a core option for mame instead that can be toggled on or off?

[sonninnos]

Sure, core option then if there is no way to differentiate.

[joepogo]

Thanks @sonninnos !

I am not very much of a coder, only limited and very very little experience, but if you or @grant2258 is willing to show me what i need to do or share a diff i can use and do not mind, i will close this pull request and make another one.

This way should work for everyone and not affect the other platforms.

[grant2258]

Ill do a test if it will work as a core option later on tonight as mame initializes pretty early.

edit

@sonninnos having problems compiling the master branch with gcc13 and clang15 is fine with the mame0.255 branch though.

[sonninnos]

Also would be extra nice if all code added or changed to the non-libretro part of the codebase is inside #ifdef __LIBRETRO__

[sonninnos]

Nothing I can do about that. Here on Windows with gcc 12.2.0 both build fine.

[grant2258]

Well that wont really matter its fixed in 0255 anyway can close this pull request is in as a core option.

[sonninnos]

Well the 0.255 branch isn't ready yet for prime time because it fails on many platforms in buildbot. So if the failing changes are reverted back like they are in the current branch, the problem might come back, who knows. Can't say more without knowing what and where the fails are.

[joepogo]

Thank you so much @grant2258 !

I'll be able to test this as soon @sonninnos gets the request approved. I'll close this pull request then.

Again, thank you so much!

[joepogo]

Pull request now closed as this affected other platforms and a toggle option will be added for threading.