Skip to content

Comments

Add compatibility with FFMPEG 7.0#16499

Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom
eclipseo:fix_for_ffmpeg7
May 9, 2024
Merged

Add compatibility with FFMPEG 7.0#16499
LibretroAdmin merged 1 commit intolibretro:masterfrom
eclipseo:fix_for_ffmpeg7

Conversation

@eclipseo
Copy link
Contributor

@eclipseo eclipseo commented May 5, 2024

channel_layout has been replaced with ch_layout

Fix: #16437

@eclipseo eclipseo force-pushed the fix_for_ffmpeg7 branch 6 times, most recently from 0a0b6a8 to 5847496 Compare May 8, 2024 08:14
@LibretroAdmin
Copy link
Contributor

I have asked @hizzlekizzle to test this. Thanks for doing this.

@hizzlekizzle
Copy link
Collaborator

@LibretroAdmin just got done testing and all seems well. It does what it says on the tin.

channel_layout has been replaced with ch_layout

Fix: libretro#16437
@eclipseo eclipseo force-pushed the fix_for_ffmpeg7 branch from 5847496 to 4a10471 Compare May 9, 2024 08:27
@eclipseo
Copy link
Contributor Author

eclipseo commented May 9, 2024

@LibretroAdmin just got done testing and all seems well. It does what it says on the tin.

Simplified the code following feedback from another patch from another project.

@LibretroAdmin
Copy link
Contributor

Confirmed with @hizzlekizzle that the latest patch worked for him.

Thanks so much for this. This will make ffmpeg viable again on Linux.

@LibretroAdmin LibretroAdmin merged commit bff678c into libretro:master May 9, 2024
@eclipseo eclipseo deleted the fix_for_ffmpeg7 branch May 12, 2024 11:32
emilazy added a commit to emilazy/nixpkgs that referenced this pull request Aug 20, 2024
FFmpeg 7 support was added in 1.19.0; see
<libretro/RetroArch#16499>.
greg-hellings pushed a commit to greg-hellings/nixpkgs that referenced this pull request Aug 24, 2024
FFmpeg 7 support was added in 1.19.0; see
<libretro/RetroArch#16499>.
Sunderland93 pushed a commit to Sunderland93/RetroArch that referenced this pull request Dec 26, 2024
channel_layout has been replaced with ch_layout

Fix: libretro#16437
@nunotexbsd
Copy link

@LibretroAdmin

Hello

1.21.0 fails to build with FFmpeg 8, should I open a new PR?

<snip>
record/drivers/record_ffmpeg.c:377:25: error: use of undeclared identifier 'AV_INPUT_BUFFER_MIN_SIZE'
  377 |    audio->outbuf_size = AV_INPUT_BUFFER_MIN_SIZE;
      |                         ^
record/drivers/record_ffmpeg.c:954:7: warning: call to undeclared function 'avcodec_close'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  954 |       avcodec_close(handle->audio.codec);
      |       ^
record/drivers/record_ffmpeg.c:962:7: warning: call to undeclared function 'avcodec_close'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  962 |       avcodec_close(handle->video.codec);
      |       ^
2 warnings and 1 error generated.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail to build with ffmpeg 7.0

4 participants