Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding cat powers #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding cat powers #6

wants to merge 2 commits into from

Conversation

rucarrol
Copy link

Meow.

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@murrant
Copy link
Member

murrant commented Oct 20, 2017

If we update this bot for discord, you can embed the images :)

murrant
murrant reviewed Nov 9, 2017
View reviewed changes
librenms.coffee
@@ -31,3 +31,9 @@ module.exports = (robot) ->
robot.hear /(.*)allah is doing(.*)/i, (msg) ->
user = msg.message.user.name
robot.adapter.command "KICK", channel, user, nick, "Not here!"
robot.hear /^kitty$/i, (msg) ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be robot.respond That way we only get kitty pics when we ask for them :)

murrant
murrant reviewed Nov 9, 2017
View reviewed changes
librenms.coffee
@@ -31,3 +31,9 @@ module.exports = (robot) ->
robot.hear /(.*)allah is doing(.*)/i, (msg) ->
user = msg.message.user.name
robot.adapter.command "KICK", channel, user, nick, "Not here!"
robot.hear /^kitty$/i, (msg) ->
user = msg.message.user.name
msg.reply "#{user}: here's a kitty http://thecatapi.com/api/images/get?format=src&type=gif"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need the #{user}: part when doing msg.reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murrant murrant murrant left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rucarrol @CLAassistant @murrant