Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update init checks to be less restrictive #347

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

duhow
Copy link
Contributor

@duhow duhow commented Apr 20, 2023

As of #283 restrictive check, Docker images after 22.6.0 are not working properly for us.

We are running LibreNMS in Kubernetes, where we have the config.php mounted as ConfigMap (read-only for the file system), and also Redis has disabled FLUSHDB as a safety measure.

Changes applied in here:

  • Ignore errors if cannot clean config.d folder initially.
  • Create new config.d files only if folder is writable.
  • Update chown folders only if are writtable.
  • Ignore if cache:clear fails. (Redis)

@duhow duhow requested a review from crazy-max as a code owner April 20, 2023 13:32
@duhow duhow mentioned this pull request Apr 20, 2023
@murrant
Copy link
Member

murrant commented Apr 25, 2023

Question, how do you clear possibly incompatible cached data from redis?

@duhow
Copy link
Contributor Author

duhow commented Apr 28, 2023

I haven't had the "need", but from the current test 22.6 to 23.4 I didn't find any "incompatible issues".
@murrant Would it help to show a warning message but continue running the software?

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an opt-in opt

@duhow duhow requested a review from crazy-max July 22, 2023 11:07
@duhow
Copy link
Contributor Author

duhow commented Oct 17, 2023

@crazy-max can you review changes again and validate?

@LoveSkylark
Copy link

I struggled with this Kubernetes + config.php and ultimately I solved this using lnms instead:
https://github.com/LoveSkylark/LibreNMS-Helm/blob/main/templates/jobs-install.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants