Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't override generics impl in proc-macros on encode impl #354

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

Nicceboy
Copy link
Contributor

Fixes #193

@Nicceboy Nicceboy changed the title fix: Don't override generics impl in proc-macros fix: Don't override generics impl in proc-macros on encode impl Oct 25, 2024
@Nicceboy
Copy link
Contributor Author

Third party crate fails the build currently.

@XAMPPRocky
Copy link
Collaborator

I'm going to merge this and we can address that separately, maybe we can exclude bench and bench related reps from some platforms.

@XAMPPRocky XAMPPRocky merged commit 2d60308 into librasn:main Oct 25, 2024
22 of 65 checks passed
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
@Nicceboy Nicceboy deleted the generic-macro-fix branch October 25, 2024 11:18
This was referenced Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traits for macro expansion not always correctly carried with generics when using Encode/Decode
2 participants