Treat Redirected Go Packages as Removed (#3358)

* set removed for redirected go packages

* use simpler http stubs for check status specs

app/models/project.rb

@@ -646,7 +646,7 @@ def check_status
     response = Typhoeus.get(url)
     if platform.downcase == "packagist" && [302, 404].include?(response.response_code)
       update_attribute(:status, "Removed")
-    elsif platform.downcase == "go" && [400, 404].include?(response.response_code)
+    elsif platform.downcase == "go" && [302, 400, 404].include?(response.response_code)
       # pkg.go.dev can be 404 on first-hit for a new package (or alias for the package), so ensure that the package existed in the past
       # by ensuring its age is old enough to not be just uncached by pkg.go.dev yet.
       update_attribute(:status, "Removed") if created_at < 1.week.ago

spec/models/project_spec.rb

@@ -210,29 +210,49 @@
     end
 
     context "a go project missing from upstream" do
+      let(:check_status_url) { PackageManager::Go.check_status_url(project) }
+
       context "recently created" do
         let!(:project) { create(:project, platform: "Go", name: "github.com/some-nonexistent-fake/pkg", status: nil, created_at: 1.hour.ago) }
 
-        it "should not mark it as Removed" do
-          VCR.use_cassette("project/check_status/go") do
-            project.check_status
-            project.reload
-            expect(project.status).to eq(nil)
-            expect(project.status_checked_at).to eq(DateTime.current)
-          end
+        it "should not mark it as Removed for a 404" do
+          WebMock.stub_request(:get, check_status_url).to_return(status: 404)
+
+          project.check_status
+          project.reload
+          expect(project.status).to eq(nil)
+          expect(project.status_checked_at).to eq(DateTime.current)
+        end
+
+        it "should not mark it as Removed for a 302" do
+          WebMock.stub_request(:get, check_status_url).to_return(status: 302)
+
+          project.check_status
+          project.reload
+          expect(project.status).to eq(nil)
+          expect(project.status_checked_at).to eq(DateTime.current)
         end
       end
 
       context "not recently created" do
         let!(:project) { create(:project, platform: "Go", name: "github.com/some-nonexistent-fake/pkg", status: nil, created_at: 1.month.ago) }
 
-        it "should mark it as Removed" do
-          VCR.use_cassette("project/check_status/go") do
-            project.check_status
-            project.reload
-            expect(project.status).to eq("Removed")
-            expect(project.status_checked_at).to eq(DateTime.current)
-          end
+        it "should mark it as Removed for a 404" do
+          WebMock.stub_request(:get, check_status_url).to_return(status: 404)
+
+          project.check_status
+          project.reload
+          expect(project.status).to eq("Removed")
+          expect(project.status_checked_at).to eq(DateTime.current)
+        end
+
+        it "should mark it as Removed for a 302" do
+          WebMock.stub_request(:get, check_status_url).to_return(status: 302)
+
+          project.check_status
+          project.reload
+          expect(project.status).to eq("Removed")
+          expect(project.status_checked_at).to eq(DateTime.current)
         end
       end
     end