fix(ping/rust): Implemented 0.50 changes #83
Conversation
|
@mxinden I can't merge this myself, please have a look! |
|
19a8de2 is not correct. Since it's called in an async_std block Tokio is the wrong executor and might lead to a runtime panic if I'm correct. In other words: If Tokio is correct, we should also use Tokio::main |
You are absolutely right @umgefahren. My bad. Sorry for pushing a wrong commit to your branch. Regarding the previous CI failure, my best next guess is that the commit hash referenced in the test-plans/ping/rust/Cargo.toml Line 34 in 31a1288 Would you mind reverting my commit and updating the commit hash to a recent commit on |
| @@ -31,5 +31,5 @@ libp2pv0490 = { package = "libp2p", version = "0.49.0", features = ["websocket", | |||
| [dependencies."libp2pv0500"] | |||
| package = "libp2p" | |||
| git = "https://github.com/libp2p/rust-libp2p" | |||
| rev = "368705a1465c4322948d14ee46d42475c472ca1e" # This should usually point to a commit on master. | |||
| tag = "v0.50.0" | |||
There was a problem hiding this comment.
I don't think moving to tag would work here, given that we use sed in our Dockerfile matching on the string rev.
I might have been not very clear. Sorry. Let's use the commit hash that v0.50.0 points at.
There was a problem hiding this comment.
Now that we have released v0.50.0 we should actually add that as a release and have this point to the most recent hash on master here!
There was a problem hiding this comment.
Should this be part of this PR?
There was a problem hiding this comment.
It doesn't have to be. I think we can merge this separately :)
There was a problem hiding this comment.
I opened #87 and also fixed the deprecation warnings there.
|
Closing here in favor of #87. Thanks for the help! |
As requested by @thomaseizinger, this changes the test plans to take the removed APIs into account. See libp2p/rust-libp2p#3170 for details.