Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(multidim-interop): add go v0.31 #289

Merged
merged 4 commits into from
Sep 7, 2023
Merged

chore(multidim-interop): add go v0.31 #289

merged 4 commits into from
Sep 7, 2023

Conversation

p-shahi
Copy link
Member

@p-shahi p-shahi commented Aug 31, 2023

No description provided.

@marten-seemann
Copy link
Contributor

Resolved by #295.

@p-shahi
Copy link
Member Author

p-shahi commented Sep 5, 2023

@marten-seemann #295 adds this to perf/ not multidim-interop/

@p-shahi p-shahi reopened this Sep 5, 2023
@p-shahi p-shahi changed the title chore: add go v0.31, rm v0.29 chore(multidim-interop): add go v0.31, rm v0.29 Sep 6, 2023
@p-shahi
Copy link
Member Author

p-shahi commented Sep 6, 2023

Failure is a flaky test: chromium-js-v0.46 x rust-v0.52 (webrtc-direct),failure

@marten-seemann
Copy link
Contributor

@marten-seemann #295 adds this to perf/ not multidim-interop/

Sorry, I must have missed that!

Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing v0.29? It's the version that's used on the latest Kubo release? What's the policy you're following here to drop v0.27 and v0.28?

We should consider dropping v0.30 though, because it was never deployed.

@p-shahi
Copy link
Member Author

p-shahi commented Sep 6, 2023

What's the policy you're following here to drop v0.27 and v0.28?

v0.27 and v0.28 were already removed in #269 - I'm doing some cleanup in this PR

No strict policy but the rationale for removing older versions was discussed here: https://filecoinproject.slack.com/archives/C03K82MU486/p1691624748108769

i.e. we can use the PRs as a place to decide whether it's ok to remove an old version.

If you think we should keep v0.29 for a bit longer I'm ok to add it back.
Dropping v0.30 because it wasn't widely deployed doesn't seem like a compelling enough reason to me - shouldn't the versions tested here be contiguous?

@marten-seemann
Copy link
Contributor

shouldn't the versions tested here be contiguous?

I don't see why. We should be testing what's in use. v0.30 was primarily a release to get Go 1.21 compatibility in.

@p-shahi
Copy link
Member Author

p-shahi commented Sep 7, 2023

shouldn't the versions tested here be contiguous?

I don't see why. We should be testing what's in use. v0.30 was primarily a release to get Go 1.21 compatibility in.

Let's keep it and drop it when 0.32 is released? Unless you feel super strongly this is my preference

@marten-seemann
Copy link
Contributor

As long as we keep testing v0.29, this is fine. I see you re-added it, can you update the title of this PR as well?

@p-shahi p-shahi changed the title chore(multidim-interop): add go v0.31, rm v0.29 chore(multidim-interop): add go v0.31 Sep 7, 2023
@p-shahi
Copy link
Member Author

p-shahi commented Sep 7, 2023

Done

@p-shahi
Copy link
Member Author

p-shahi commented Sep 7, 2023

image

@p-shahi p-shahi merged commit fa6dc4c into master Sep 7, 2023
2 checks passed
@p-shahi p-shahi deleted the add-go-v0.31 branch September 7, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants