fix(interop/rust/wasm): bump version to use chrome 115 #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump rust-libp2p v0.52 interop version to include libp2p/rust-libp2p#4383 which fixes issue in libp2p/go-libp2p#2506.
mxinden
commented
Aug 23, 2023
There was a problem hiding this comment.
See #253 (comment) for rational on using old commitSha mechanism instead of version mechanism.
There was a problem hiding this comment.
This makefile has assumptions about fetching using a tag so it needs to be changed to mirror 0.51.0
There was a problem hiding this comment.
Np ultimately caused by me since I moved to use tags :(
It seems like using commit hash has it's own advantages
|
CI logs: |
MarcoPolo
approved these changes
Aug 23, 2023
thomaseizinger
approved these changes
Aug 24, 2023
marten-seemann
approved these changes
Aug 24, 2023
|
Most approved pull request. Thank you. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump rust-libp2p v0.52 interop version to include
libp2p/rust-libp2p#4383 which fixes issue in libp2p/go-libp2p#2506.