fix(aws): Only set bucket var when creds are available #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `dockerBuildWrapper` script enables caching based on the `AWS_BUCKET` environment variable. When calling the `libp2p ping interop test` with a bucket name but no AWS credentials, this leads to the script enabling caching even though the workflow does not have access to AWS. With this commit the environment variable `AWS_BUCKET` is only set when credentials are available and thus the `dockerBuildWrapper` script does not enable caching then workflow does nothave access to AWS.
MarcoPolo
approved these changes
Feb 13, 2023
Member
Author
|
🙏 thanks for the quick help @MarcoPolo! |
codemaestro64
pushed a commit
to codemaestro64/test-plans
that referenced
this pull request
Oct 28, 2025
The `dockerBuildWrapper` script enables caching based on the `AWS_BUCKET` environment variable. When calling the `libp2p ping interop test` with a bucket name but no AWS credentials, this leads to the script enabling caching even though the workflow does not have access to AWS. With this commit the environment variable `AWS_BUCKET` is only set when credentials are available and thus the `dockerBuildWrapper` script does not enable caching then workflow does nothave access to AWS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dockerBuildWrapperscript enables caching based on theAWS_BUCKETenvironment variable. When calling thelibp2p ping interop testwith a bucket name but no AWS credentials, this leads to the script enabling caching even though the workflow does not have access to AWS.With this commit the environment variable
AWS_BUCKETis only set when credentials are available and thus thedockerBuildWrapperscript does not enable caching then workflow does nothave access to AWS.Not deeply familiar with the setup. Let me know in case there are cleaner solutions.
See also libp2p/rust-libp2p#3462 and the corresponding failure on its first commit.