Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js-libp2p webrtc tests flaky #235

Closed
MarcoPolo opened this issue Jul 14, 2023 · 7 comments · Fixed by #310
Closed

js-libp2p webrtc tests flaky #235

MarcoPolo opened this issue Jul 14, 2023 · 7 comments · Fixed by #310

Comments

@MarcoPolo
Copy link
Contributor

Related: libp2p/js-libp2p#1846

There's a lot of stuff in the stack, so this needs investigation as to what is being flaky. Is it:

  • js-libp2p
  • js-libp2p-webrtc
  • js-libp2p circuitV2
  • js-libp2p p2p-circuit transport
  • Browser itself
  • Something else?

My hope is that it's not the browser as everything else is easier to fix. Maybe a very simple non-js-libp2p browser only interop test would be a good way to test if the browser is at fault.

@MarcoPolo
Copy link
Contributor Author

cc @maschad

@maschad
Copy link
Member

maschad commented Jul 17, 2023

Thanks for writing this up.

My hope is that it's not the browser as everything else is easier to fix. Maybe a very simple non-js-libp2p browser only interop test would be a good way to test if the browser is at fault.

Just to clarify, when you reference browser in this context are you referring to https://github.com/hugomrdias/playwright-test which aegir uses for browser testing right?

@MarcoPolo
Copy link
Contributor Author

I would use https://playwright.dev directly, avoiding Aegir and playwright-test.

I'll probably do this at some point this week, but if you have bandwidth and it seems interesting, let me know and you can take.

@maschad
Copy link
Member

maschad commented Jul 17, 2023

Good point, Thanks for clarifying. I will take a look into it this week.

@MarcoPolo
Copy link
Contributor Author

Sounds good. Let's sync up when you get a chance.

@sukunrt
Copy link
Member

sukunrt commented Sep 26, 2023

Is there any update here? We are adding support for webrtc in go-libp2p and it'd be nice to test interop with js-libp2p. I have pretty much copied the js-libp2p test implementation: libp2p/go-libp2p#2584

@maschad
Copy link
Member

maschad commented Oct 1, 2023

We will revisit once libp2p/js-libp2p#2074 is merged, this issue is causing the current webRTC tests to be flaky in js-libp2p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants