v0.8.1 #115
Merged
v0.8.1 #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
approved these changes
Feb 16, 2021
tomaka
approved these changes
Feb 16, 2021
Member
tomaka
left a comment
tomaka
left a comment
There was a problem hiding this comment.
I haven't reviewed the logic, but if nobody else reviews I can give you an approval
mxinden
approved these changes
Feb 16, 2021
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
To avoid surprises, it seems best to backport the part of v0.9 that ignores received frames for unknown streams into a v0.8.1 release. Otherwise nodes running v0.8 may react with a stream reset if they get a window update from a node running v0.9 while the stream is already closing. Rolling out v0.8.1 first should avoid such hiccups.
Yes, good point! 👍
This was referenced Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid surprises, it seems best to backport the part of
v0.9that ignores received frames for unknown streams into av0.8.1release. Otherwise nodes runningv0.8may react with a stream reset if they get a window update from a node runningv0.9while the stream is already closing. Rolling outv0.8.1first should avoid such hiccups.cc @mxinden