Skip to content

fix(gossisub): prevent mesh exceeding mesh_n_high #6184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 24, 2025
Merged

fix(gossisub): prevent mesh exceeding mesh_n_high #6184

merged 5 commits into from
Oct 24, 2025

Conversation

@jxs
Copy link
Member

@jxs jxs commented Oct 17, 2025 •
edited
Loading

Description

Split off from #6183, to quote:

I noticed two issues during testing.

We allow our mesh to grow greater than mesh_n_high, intentionally
This looks like its intentional but I can't recall why we would have added it. I think its counter-intuitive to allow our mesh to grow larger than the specified parameter. I suspect we added it to prevent our mesh from being filled with inbound peers and potentially being eclipsed. I suspect the best approach here is to remove inbound peers in the mesh maintenance rather than exceeding the mesh_n_high configuration.

@jxs jxs force-pushed the gossipsub-fix-mesh-low branch from 18efa2c to 3176449 Compare October 18, 2025 00:22
elenaf9
elenaf9 approved these changes Oct 19, 2025
View reviewed changes
@jxs jxs force-pushed the gossipsub-fix-mesh-low branch from 3d1f64c to 9a347c4 Compare October 22, 2025 12:41
@jxs jxs force-pushed the gossipsub-fix-mesh-low branch from 9a347c4 to 4fa65cc Compare October 22, 2025 13:04
@jxs jxs force-pushed the gossipsub-fix-mesh-low branch from 4fa65cc to 211eb44 Compare October 23, 2025 14:53
@jxs jxs changed the title fix(gossisub): prevent mesh exceeding mesh_n_high when handling GRAFTs fix(gossisub): prevent mesh exceeding mesh_n_high Oct 23, 2025
jxs
jxs commented Oct 23, 2025
View reviewed changes
AgeManning
AgeManning reviewed Oct 24, 2025
View reviewed changes
Copy link
Contributor

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah nice. This looks good to me

@jxs jxs added the send-it label Oct 24, 2025
@mergify mergify bot added the queued label Oct 24, 2025
@mergify mergify bot merged commit e0e6037 into libp2p:master Oct 24, 2025
70 checks passed
@mergify mergify bot removed the queued label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AgeManning AgeManning AgeManning left review comments

@elenaf9 elenaf9 elenaf9 approved these changes

Assignees

No one assigned

Labels

send-it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jxs @AgeManning @elenaf9