Skip to content

Conversation

@hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Nov 28, 2024

Description

Ignore RUSTSEC-2024-0384 in deny.toml to let CI pass.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@hanabi1224 hanabi1224 marked this pull request as ready for review November 28, 2024 09:22
@drHuangMHT
Copy link
Contributor

cargo-deny test is not required to merge a PR, I don't think this is necessary.

@jxs
Copy link
Member

jxs commented Nov 29, 2024

Thanks for this @hanabi1224, and for your work on rust-netlink/netlink-sys#25!
I agree with @drHuangMHT I'd rather have CI red and confronting/recalling us to act (deprecating async-std) than silently ignore this issue.

@hanabi1224 hanabi1224 closed this Dec 2, 2024
@hanabi1224 hanabi1224 deleted the deny-toml branch December 2, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants