fix(request-response): Report failure when streams are at capacity #5417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oblique
changed the title
oblique
changed the title
oblique
changed the title
|
@jxs We will appreciate it if this can make it to 0.54. |
4 tasks
oblique
changed the title
|
This pull request has merge conflicts. Could you please resolve them @oblique? 🙏 |
mergify
bot
dismissed
jxs’s stale review
Approvals have been dismissed because the PR was updated after the send-it label was applied.
jxs
approved these changes
Jun 4, 2024
|
@jxs I was under impression that 0.26.3 is already released, but it is not on crates.io 🤔 |
TimTinkers
pushed a commit
to unattended-backpack/rust-libp2p
that referenced
this pull request
Sep 14, 2024
Fixes potential hanging issue if use relies on response or failures to make progress Pull-Request: libp2p#5417.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes potential hanging issue if use relies on response or failures to make progress
Notes & open questions
We are investigating a bug in our project (eigerco/lumina#256) and @zvolin found out that when an outbound request can not be scheduled it didn't produce any errors.
Inbound requests do not need to produce this kind of error because they only get reported to the user when they successfully been scheduled.
Change checklist