chore: use path dependencies for all cyclic dev-dependencies
#4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mxinden
approved these changes
Jun 20, 2023
| libp2p-mplex = { workspace = true } | ||
| libp2p-noise = { workspace = true } | ||
| libp2p-mplex = { path = "../muxers/mplex" } # Using `path` here because this is a cyclic dev-dependency which otherwise breaks releasing. | ||
| libp2p-noise = { path = "../transports/noise" } # Using `path` here because this is a cyclic dev-dependency which otherwise breaks releasing. | ||
| multihash = { workspace = true , features = ["arb"] } | ||
| quickcheck = { workspace = true } | ||
| libp2p-identity = { workspace = true, features = ["ed25519"] } |
There was a problem hiding this comment.
Suggested change
| libp2p-identity = { workspace = true, features = ["ed25519"] } |
Already imported in [dependencies].
There was a problem hiding this comment.
Will keep as is for now as I don't understand the motivation behind this additional line. See also https://github.com/libp2p/rust-libp2p/pull/4040/files#r1234767608.
There was a problem hiding this comment.
I don't remember a particular rationale so this is fine to remove.
There was a problem hiding this comment.
Ah I think I do remember. The ed25519 feature should not be present in the prod dependencies but I activated it temporarily because we had a bug with an old version of libp2p-identity.
|
Restarted failed interop test and reported flake: libp2p/test-plans#197 (comment) |
mxinden
added a commit
to mxinden/rust-libp2p
that referenced
this pull request
Aug 11, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have two "interface" crates in our workspace:
libp2p-coreandlibp2p-swarm. Most crates depend on both of these. To compile the tests for this crate, we often need a concrete implementation to some of these interfaces. When specifying a workspace-inherited dependency, we don't get to choose to omit theversionfield next to the path. If a dependency ispath-only however, it will be tripped bycargoduring the release process which is why all of this worked before our move to workspace inheritance.With this patch, we change the minimum amount of dependencies necessary back to
pathdependencies to allowing releasing of our crates.Related: #4053.
Notes & open questions
The list of dependencies changed is only manually curated. I could not think of a way to test this automatically.
Change checklist