Skip to content

feat(swarm-test): allow publishing to crates.io #3629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 5 commits into from
Mar 20, 2023
Merged

feat(swarm-test): allow publishing to crates.io #3629

mergify merged 5 commits into from
Mar 20, 2023

Conversation

@mxinden
Copy link
Member

@mxinden mxinden commented Mar 17, 2023

Description

Allows folks like @bajtos to use the crate, see CheckerNetwork/zinnia#85.

I opted for not exposing the crate through the libp2p meta crate as it is a testing tool only. @thomas
let me know if you prefer me to do so.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mxinden mxinden requested a review from thomaseizinger March 17, 2023 15:40
@mxinden mxinden mentioned this pull request Mar 17, 2023
Merged
thomaseizinger
thomaseizinger approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

No need for re-export.

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Mar 17, 2023

cc @melekes

thomaseizinger
thomaseizinger reviewed Mar 17, 2023
View reviewed changes
@bajtos
Copy link

bajtos commented Mar 20, 2023

Awesome, thank you guys! 👏🏻

thomaseizinger
thomaseizinger requested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libp2p-swarm-test is wrongly included as a production dependency in libp2p-perf hence that build is now failing.

@mxinden mxinden requested a review from thomaseizinger March 20, 2023 16:37
@thomaseizinger
Copy link
Contributor

thomaseizinger commented Mar 20, 2023

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2023

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 9f63a0a into libp2p:master Mar 20, 2023
@thomaseizinger
Copy link
Contributor

thomaseizinger commented Mar 20, 2023

I think before we want to release this, we also need to specify a version for each dependency and not just a path reference.

This was referenced Mar 20, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Mar 21, 2023
@thomaseizinger
chore(swarm-test): specify versions for dependencies
0341817 
Every crate released to crates.io must have versions specified for all prod. dependencies.

Related: #3629.

Pull-Request: #3650.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees

No one assigned

Labels

send-it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mxinden @thomaseizinger @bajtos