feat(swarm)!: introduce ListenError
#3375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
thomaseizinger
changed the title
ListenErrorListenError
mxinden
approved these changes
Jan 25, 2023
|
|
||
| /// Possible errors when upgrading an inbound connection. | ||
| #[derive(Debug)] | ||
| pub enum ListenError { |
Member
There was a problem hiding this comment.
Mentioning it here, though not directly related: I always confuse LIstenError, signaling a failure on upgrading an inbound connection, with the failure of listening on a new address. Anyone else?
Contributor
Author
There was a problem hiding this comment.
A lot of naming could be improved here :)
I believe this is consistent with the naming of DialError but I agree that something like InboundConnectionError and OutboundConnectionError would probably be better.
I'll see to tidy up these when we remove the connection limits and banned variants.
Base automatically changed from
2824-remove-unused-connection-error
to
master
January 26, 2023 08:10
Contributor
|
This pull request has merge conflicts. Could you please resolve them @thomaseizinger? 🙏 |
Contributor
|
This pull request has merge conflicts. Could you please resolve them @thomaseizinger? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case an error happens for an outgoing connection,
Poolreports anOutgoingConnectionError. This one is mapped to aDialErrorand reported viaSwarmEvent::OutgoingConnectionErrorandFromSwarm::DialFailure.For incoming connections, we didn't quite do the same thing. For one,
SwarmEvent::IncomingConnectionErrordirectly contained aPendingInboundConnectionError. Two,FromSwarm::ListenFailuredid not include an error at all.With this patch, we now introduce a
ListenErrorenum which we use inSwarmEvent::IncomingConnectionErrorand we pass a reference to it along inFromSwarm::ListenFailure.Notes
In #3254, I am going to introduce a
Deniedvariant in bothDialErrorandListenErrorwhich contains the error that aNetworkBehaviourdenied a connection with.Links to any relevant issues
Open Questions
Change checklist
I have added tests that prove my fix is effective or that my feature works