refactor(relay): directly store actions instead of events #3372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jxs
approved these changes
Jan 24, 2023
Member
jxs
left a comment
jxs
left a comment
There was a problem hiding this comment.
Yeah agree with your reasoning, LGTM Thomas
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Storing
NetworkBehaviourActions within the behaviour is more flexible than only storingOutEvents. Additionally, I find expression-oriented code easier to reason about because it typically doesn't contain side-effects.Notes
This will reduce the diff in #3328.
Links to any relevant issues
Open Questions
Change checklist