docs(pnet): use backticks for referencing types#3252
Merged
Conversation
This was referenced Dec 16, 2022
jxs
approved these changes
Dec 16, 2022
jxs
changed the title
Contributor
Author
|
@Mergifyio backport rust-v050-testplan |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Feb 10, 2023
With the update to Rust 1.66, rustdoc is (rightfully) complaining about us writing bad HTML. `<u8>` is interpreted as an unclosed HTML tag. See https://github.com/libp2p/rust-libp2p/actions/runs/3708901592/jobs/6286942010#step:6:1380 for example. (cherry picked from commit e960aab)
thomaseizinger
added a commit
that referenced
this pull request
Feb 10, 2023
docs(pnet): use backticks for referencing types (#3252) With the update to Rust 1.66, rustdoc is (rightfully) complaining about us writing bad HTML. `<u8>` is interpreted as an unclosed HTML tag. See https://github.com/libp2p/rust-libp2p/actions/runs/3708901592/jobs/6286942010#step:6:1380 for example. (cherry picked from commit e960aab) Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Contributor
Author
|
@Mergifyio backport rust-v049-testplan rust-v048-testplan |
Contributor
❌ No backport have been createdDetails
|
Contributor
Author
|
@Mergifyio backport rust-v049-testplan |
Contributor
❌ No backport have been createdDetails
|
Contributor
Author
|
@Mergifyio backport rust-v048-testplan |
Contributor
❌ No backport have been createdDetails
|
Contributor
Author
|
@Mergifyio backport rust-v0490-testplan rust-v0480-testplan |
mergify Bot
pushed a commit
that referenced
this pull request
Feb 10, 2023
With the update to Rust 1.66, rustdoc is (rightfully) complaining about us writing bad HTML. `<u8>` is interpreted as an unclosed HTML tag. See https://github.com/libp2p/rust-libp2p/actions/runs/3708901592/jobs/6286942010#step:6:1380 for example. (cherry picked from commit e960aab)
mergify Bot
pushed a commit
that referenced
this pull request
Feb 10, 2023
With the update to Rust 1.66, rustdoc is (rightfully) complaining about us writing bad HTML. `<u8>` is interpreted as an unclosed HTML tag. See https://github.com/libp2p/rust-libp2p/actions/runs/3708901592/jobs/6286942010#step:6:1380 for example. (cherry picked from commit e960aab)
Contributor
✅ Backports have been createdDetails
|
thomaseizinger
added a commit
that referenced
this pull request
Feb 10, 2023
docs(pnet): use backticks for referencing types (#3252) With the update to Rust 1.66, rustdoc is (rightfully) complaining about us writing bad HTML. `<u8>` is interpreted as an unclosed HTML tag. See https://github.com/libp2p/rust-libp2p/actions/runs/3708901592/jobs/6286942010#step:6:1380 for example. (cherry picked from commit e960aab) Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
thomaseizinger
added a commit
that referenced
this pull request
Feb 10, 2023
docs(pnet): use backticks for referencing types (#3252) With the update to Rust 1.66, rustdoc is (rightfully) complaining about us writing bad HTML. `<u8>` is interpreted as an unclosed HTML tag. See https://github.com/libp2p/rust-libp2p/actions/runs/3708901592/jobs/6286942010#step:6:1380 for example. (cherry picked from commit e960aab) Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the update to Rust 1.66, rustdoc is (rightfully) complaining about us writing bad HTML.
<u8>is interpreted as an unclosed HTML tag. See https://github.com/libp2p/rust-libp2p/actions/runs/3708901592/jobs/6286942010#step:6:1380 for example.Notes
Need urgent approval please as this is blocking other PRs from merging.
Links to any relevant issues
Open Questions
Change checklist