Skip to content

Updating protocols/identify's cache to default to a size of 100#3045

Closed
nloadholtes wants to merge 1 commit intolibp2p:masterfrom
nloadholtes:nloadholtes/it-can-not-be-that-easy-cache-change
Closed

Updating protocols/identify's cache to default to a size of 100#3045
nloadholtes wants to merge 1 commit intolibp2p:masterfrom
nloadholtes:nloadholtes/it-can-not-be-that-easy-cache-change

Conversation

@nloadholtes
Copy link
Contributor

@nloadholtes nloadholtes commented Oct 19, 2022

Description

Changed the default_size from 0 to 100.

Links to any relevant issues

Addresses #2933

Open Questions

This can't be all that's needed, can it?

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@nloadholtes
Copy link
Contributor Author

PR: #2995 Is already doing this, so I'm closing this one in favor of that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant