Updating protocols/identify's cache to default to a size of 100#3045
Closed
nloadholtes wants to merge 1 commit intolibp2p:masterfrom
Closed
Updating protocols/identify's cache to default to a size of 100#3045nloadholtes wants to merge 1 commit intolibp2p:masterfrom
nloadholtes wants to merge 1 commit intolibp2p:masterfrom
Conversation
Contributor
Author
|
PR: #2995 Is already doing this, so I'm closing this one in favor of that one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed the
default_sizefrom 0 to 100.Links to any relevant issues
Addresses #2933
Open Questions
This can't be all that's needed, can it?
Change checklist