Skip to content

protocols/identify: Change default cache_size of Config to 100 #2995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 11 commits into from
Nov 4, 2022
+7 −5
Merged

protocols/identify: Change default cache_size of Config to 100 #2995

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1b67948
protocols/identify: Change default cache_size of Config to 100
efarg Oct 6, 2022
c52625d
Update protocols/identify/CHANGELOG.md
efarg Oct 11, 2022
7288f29
Update protocols/identify/CHANGELOG.md
efarg Oct 11, 2022
38c2e76
Update protocols/identify/CHANGELOG.md
efarg Oct 11, 2022
4237a6f
Update protocols/identify/CHANGELOG.md
thomaseizinger Oct 11, 2022
a57b0a2
Merge branch 'master' into 2933_
thomaseizinger Oct 11, 2022
3d33643
Fix formatting
thomaseizinger Oct 11, 2022
8f426a2
Merge branch 'master' into 2933_
mxinden Oct 14, 2022
d822863
protocols/identify: version bumped to v0.41.0
efarg Oct 17, 2022
a63a0a1
Merge branch 'master' of https://github.com/libp2p/rust-libp2p into 2…
mxinden Nov 4, 2022
223e273
Update CHANGELOG.md
mxinden Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
- Update to [`libp2p-dns` `v0.37.0`](transports/dns/CHANGELOG.md#0370).
- Update to [`libp2p-floodsub` `v0.40.0`](protocols/floodsub/CHANGELOG.md#0400).
- Update to [`libp2p-gossipsub` `v0.42.0`](protocols/gossipsub/CHANGELOG.md#0420).
- Update to [`libp2p-identify` `v0.40.0`](protocols/identify/CHANGELOG.md#0400).
- Update to [`libp2p-identify` `v0.41.0`](protocols/identify/CHANGELOG.md#0410).
Comment thread
mxinden marked this conversation as resolved.
Outdated
- Update to [`libp2p-kad` `v0.41.0`](protocols/kad/CHANGELOG.md#0410).
- Update to [`libp2p-mdns` `v0.41.0`](protocols/mdns/CHANGELOG.md#0410).
- Update to [`libp2p-metrics` `v0.10.0`](misc/metrics/CHANGELOG.md#0100).
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ libp2p-autonat = { version = "0.8.0", path = "protocols/autonat", optional = tru
libp2p-core = { version = "0.37.0", path = "core" }
libp2p-dcutr = { version = "0.7.0", path = "protocols/dcutr", optional = true }
libp2p-floodsub = { version = "0.40.1", path = "protocols/floodsub", optional = true }
libp2p-identify = { version = "0.40.0", path = "protocols/identify", optional = true }
libp2p-identify = { version = "0.41.0", path = "protocols/identify", optional = true }
libp2p-kad = { version = "0.41.0", path = "protocols/kad", optional = true }
libp2p-metrics = { version = "0.10.0", path = "misc/metrics", optional = true }
libp2p-mplex = { version = "0.37.0", path = "muxers/mplex", optional = true }
Expand Down
6 changes: 6 additions & 0 deletions protocols/identify/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# 0.41.0

@thomaseizinger thomaseizinger Oct 19, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# 0.41.0
# 0.41.0 [unreleased]

Whilst technically not breaking, I think it is good to communicate the semantic change here in a minor version.


- Change default `cache_size` of `Config` to 100. See [PR 2995].

[PR 2995]: https://github.com/libp2p/rust-libp2p/pull/2995

# 0.40.0

- Update dependencies.
Expand Down
2 changes: 1 addition & 1 deletion protocols/identify/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "libp2p-identify"
edition = "2021"
rust-version = "1.56.1"
description = "Nodes identifcation protocol for libp2p"
version = "0.40.0"
version = "0.41.0"

@thomaseizinger thomaseizinger Oct 19, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version bump will require a change to metrics too.

authors = ["Parity Technologies <admin@parity.io>"]
license = "MIT"
repository = "https://github.com/libp2p/rust-libp2p"
Expand Down
6 changes: 2 additions & 4 deletions protocols/identify/src/behaviour.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ impl Config {
initial_delay: Duration::from_millis(500),
interval: Duration::from_secs(5 * 60),
push_listen_addr_updates: false,
cache_size: 0,
cache_size: 100,
}
}

Expand Down Expand Up @@ -748,9 +748,7 @@ mod tests {
let mut swarm2 = {
let (pubkey, transport) = transport();
let protocol = Behaviour::new(
Config::new("a".to_string(), pubkey.clone())
.with_cache_size(100)
.with_agent_version("b".to_string()),
Config::new("a".to_string(), pubkey.clone()).with_agent_version("b".to_string()),
);

Swarm::new(transport, protocol, pubkey.to_peer_id())
Expand Down