Update changelogs for prost dep update#2851
Merged
mxinden merged 4 commits intolibp2p:masterfrom Aug 30, 2022
Merged
Conversation
Member
|
thanks for the update. just a general note this is really painful when using libp2p now, as all ci flows have to be updated to manually install protoc, really unfortunate for downstream users |
Member
|
Agreed @dignifiedquire, though I don't see a solution. Do you? I don't think this is libp2p specific, but applies to any application using |
Member
|
agree it is a general prost problem, one idea I had is to make a rust crate that brings protoc with it, so one could include in its build deps |
Member
|
It seems tokio-rs/prost#620 addresses that, but has been stagnant since tokio-rs/prost#657 |
umgefahren
pushed a commit
to umgefahren/rust-libp2p
that referenced
this pull request
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Patch changelogs for #2788
Links to any relevant issues
#2848
Open Questions
na
Change checklist