*: Remove inject_connected / inject_disconnected from docs
#2805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K0UR05H
changed the title
inject_connected / inject_disconnected in commentsinject_connected / inject_disconnected from docs
thomaseizinger
changed the title
inject_connected / inject_disconnected from docsinject_connected / inject_disconnected from docs
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Thank you!
One suggestion.
swarm/src/behaviour.rs
Outdated
| /// for the behaviour. | ||
| /// | ||
| /// The `peer_id` is guaranteed to be in a connected state. In other words, `inject_connected` | ||
| /// The `peer_id` is guaranteed to be in a connected state. In other words, `inject_connection_established` |
Contributor
There was a problem hiding this comment.
Lets change this and other rustdoc appearances to an actual reference with [``].
That will yield a compile-error if we ever hit this again.
Contributor
Author
There was a problem hiding this comment.
Thanks for your review. I changed them.
mxinden
reviewed
Aug 10, 2022
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Thanks for the help here. Please wrap the lines at 80 or 120 characters. Otherwise, this looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both
inject_connectedandinject_disconnectedare removed in dc8433e.Links to any relevant issues
Open Questions
Change checklist