Skip to content

swarm/src/handler: Document responsibility limiting inbound streams #2752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mxinden merged 1 commit into from
Jul 14, 2022
Merged

swarm/src/handler: Document responsibility limiting inbound streams #2752

mxinden merged 1 commit into from
Jul 14, 2022

Conversation

@mxinden
Copy link
Member

@mxinden mxinden commented Jul 13, 2022

Description

Document that the ConnectionHandler implementation has to enforce a limit on
the number of inbound substreams.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mxinden
swarm/src/handler: Document responsibility limiting inbound streams
036f855 
Document that the `ConnectionHandler` implementation has to enforce a limit on
the number of inbound substreams.
@mxinden mxinden requested a review from thomaseizinger July 13, 2022 06:57
@mxinden
Copy link
Member Author

mxinden commented Jul 14, 2022

Thanks for the review @thomaseizinger!

@mxinden mxinden merged commit 7c8a977 into libp2p:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mxinden @thomaseizinger