Update Dial Concurrency factor #2741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maschad
force-pushed
the
update-dial-concurrency-value
branch
from
0d0dcbd to
8a3b0a5
Compare
mxinden
reviewed
Jul 4, 2022
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Two small comments, otherwise this looks good to me. Thanks!
maschad
force-pushed
the
update-dial-concurrency-value
branch
2 times, most recently
from
86c4279 to
8d3e688
Compare
maschad
force-pushed
the
update-dial-concurrency-value
branch
from
8d3e688 to
4efd77e
Compare
Member
Author
|
Thanks for the review @mxinden , I've made the suggested changes. |
mxinden
approved these changes
Jul 7, 2022
mxinden
added a commit
to mxinden/rust-libp2p
that referenced
this pull request
Mar 4, 2023
Since libp2p#2741 the default dial concurrency factor is > 1, more specifically 8. Thus there is no need to explicitly set it anylonger.
umgefahren
pushed a commit
to umgefahren/rust-libp2p
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increased the default dial concurrency factor to 8 based on the bottom dialer number of connections as well as the go-libp2p uses a dial concurrency factor of 8
Links to any relevant issues
Part of #2678
Open Questions
Change checklist