protocols/gossipsub: Fix a typo in error message #2739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
approved these changes
Jun 29, 2022
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Nope, changelog not required for this, thank you!
protocols/gossipsub/src/behaviour.rs
Outdated
Comment on lines
1529
to
1532
| .is_err() | ||
| { | ||
| error!("Failed to send graft. Message too large"); | ||
| error!("Failed to send PRUNE. Message too large"); | ||
| } |
Contributor
There was a problem hiding this comment.
Is "Message to large" really the only failure mode here? That is not obvious from just checking is_err?
Contributor
Author
There was a problem hiding this comment.
You are right. 💡 I'll update this.
Contributor
Author
|
@thomaseizinger Thank you for your review! I have updated this, please have another look when you have time. |
thomaseizinger
approved these changes
Jun 30, 2022
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Thanks, this is a good improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a typo in the error message. 😃
Please let me know if a changelog entry is needed for this pull request.
Change checklist
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksA changelog entry has been made in the appropriate crates