core/transport: Remove various Sync bounds
#2667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `Transport` becoming non-Clone and having `&mut` self receivers, the `Sync` requirement no longer makes any sense and we can thus remove it.
thomaseizinger
changed the title
Sync boundsSync bounds
27 tasks
elenaf9
approved these changes
May 23, 2022
Member
elenaf9
left a comment
elenaf9
left a comment
There was a problem hiding this comment.
Nice! I actually stumbled over that recently because it was that reason that you could not call boxed directly on the tcp transport. So this will also make #2652 (comment) easier.
Contributor
Author
|
Was about to merge this but will hold back until 0.45.0 is out. |
elenaf9
added a commit
to elenaf9/rust-libp2p
that referenced
this pull request
May 29, 2022
With PR libp2p#2667 the `Sync` trait bound for transport::Boxed is removed. If a tcp transport should be polled as a stream we can now do this via `TcpTransport::new(..)::boxed` and do not need a separate impl of `Stream` for it.
mxinden
approved these changes
May 29, 2022
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Thanks!
I am in favor of including this in v0.45.0.
Contributor
Author
Okay, up to you! |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With
Transportbecoming non-Clone and having&mutself receivers,the
Syncrequirement no longer makes any sense and we can thusremove it.
Links to any relevant issues
StreamMuxertrait #2648.Open Questions
Change checklist