Skip to content

[core/swarm] Refactor and extend configurable connection limits. #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romanb merged 6 commits into from
Nov 23, 2020
Merged

[core/swarm] Refactor and extend configurable connection limits. #1848

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2cb8b3a
Refactor and extend configurable connection limits.
Nov 18, 2020
f732c34
Cleanup
Nov 20, 2020
ee14e9c
Add missing file.
Nov 20, 2020
4e447e9
Refine naming and config API.
Nov 23, 2020
36b45e9
Update core/CHANGELOG.md
romanb Nov 23, 2020
e6e26da
Update core/CHANGELOG.md
romanb Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# 0.25.0 [unreleased]

- The `NetworkConfig` API is now a builder that moves `self`.

- New configurable connection limits for established connections and
dedicated connection counters. Removed the connection limit dedicated
to outgoing pending connection _per peer_. Connection limits are now
represented by `u32` intead of `usize` types.

- Update `multihash`.

- Update `multistream-select`.
Expand Down
5 changes: 3 additions & 2 deletions core/src/connection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ pub use listeners::{ListenerId, ListenersStream, ListenersEvent};
pub use manager::ConnectionId;
pub use substream::{Substream, SubstreamEndpoint, Close};
pub use pool::{EstablishedConnection, EstablishedConnectionIter, PendingConnection};
pub use pool::{ConnectionLimits, ConnectionCounters};

use crate::muxing::StreamMuxer;
use crate::{Multiaddr, PeerId};
Expand Down Expand Up @@ -326,9 +327,9 @@ impl<'a> OutgoingInfo<'a> {
#[derive(Debug, Clone)]
pub struct ConnectionLimit {
/// The maximum number of connections.
pub limit: usize,
pub limit: u32,
/// The current number of connections.
pub current: usize,
pub current: u32,
}

impl fmt::Display for ConnectionLimit {
Expand Down
Loading