Make the SwarmEvent report everything #1515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanb
reviewed
Mar 25, 2020
Co-Authored-By: Roman Borschel <romanb@users.noreply.github.com>
romanb
approved these changes
Mar 25, 2020
folex
added a commit
to fluencelabs/rust-libp2p
that referenced
this pull request
Mar 30, 2020
This reverts commit 7220877
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new variants and improves the existing variants of the
SwarmEventin order to report everything that happens in the swarm in terms of connectivity.This way, the outside can track exactly what happens.
Some notes:
Reporting the errors enums (rather than opaque
Box<Error>s) is going to be quite helpful in Substrate to detect connections closed because they were idle, and dial failures because of peer id mismatch.I changed some
usizes intou32s. In general,usizeshould only be used for things that depend on the platform's pointer width.I purposefully left aside the concept of "external addresses", as the way we handle them is still quite blurry at the moment.