Skip to content

replace display_version with two other options #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 28, 2024
Merged

replace display_version with two other options #481

merged 3 commits into from
Oct 28, 2024

Conversation

kazzmir
Copy link
Contributor

@kazzmir kazzmir commented Oct 25, 2024 •
edited
Loading

What was wrong?

html build uses a deprecated sphinx_rtd_theme option: display_version

$ make html
preparing documents... WARNING: unsupported theme option 'display_version' given

How was it fixed?

Replace display_version in conf.py with language_selector and version_selector, both set to false.

https://sphinx-rtd-theme.readthedocs.io/en/stable/configuring.html

To-Do

  • Clean up commit history

@kazzmir kazzmir changed the title replase display_version with two other options replace display_version with two other options Oct 28, 2024
@pacrob
Copy link
Member

pacrob commented Oct 28, 2024

Thanks, @kazzmir ! I threw in dropping the pdf docs build - I think it broke a while ago, doesn't really seem necessary.

@pacrob pacrob merged commit 0be78be into libp2p:main Oct 28, 2024
12 of 17 checks passed
@kazzmir kazzmir deleted the sphinx-update-theme-options branch October 28, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazzmir @pacrob