[WIP] Awesome API docs #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dignifiedquire
force-pushed
the
api-docs
branch
from
3446295 to
01957fa
Compare
|
It is my impression, or Coveralls forgot that we deactivated them all and now comments in all PRs? |
|
@diasdavid no we just haven't disabled them everywhere yet |
|
Nice. One nit: http://libp2p.github.io/js-peer-id/#Introduction should probably link back to https://github.com/libp2p/js-peer-id , in case someone lands there from search or something... |
victorb
suggested changes
Dec 5, 2016
src/index.js
Outdated
| get privKey () { | ||
| return this._privKey | ||
| } | ||
|
|
||
| /** | ||
| * The private key of this id, if it exists. |
|
@harlantwood just updated and added a github link: http://libp2p.github.io/js-peer-id/ |
daviddias
added
status/ready
2 tasks
|
Closing this as we already have the API docs in the README and these are outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.