Skip to content

chore: update websockets#806

Merged
jacobheun merged 2 commits into0.30.xfrom
chore/update-websockets
Nov 24, 2020
Merged

chore: update websockets#806
jacobheun merged 2 commits into0.30.xfrom
chore/update-websockets

Conversation

@vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Nov 23, 2020

This PR updates websockets version, which comes with a BREAKING CHANGE on the filter. Only DNS+WSS addresses are now returned on filter by default in the browser. The tests were update to pass a custom filter so that we can test this locally with loopback websocket addresses

Needs:

@vasco-santos vasco-santos marked this pull request as ready for review November 24, 2020 10:10
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just want to note though that while the Websocket transport behavior is a breaking change, it's a breaking change in behavior only, and there is no reason why someone cannot use libp2p-websockets 0.15 with js-libp2p 0.29.x.

It's not necessary for this to land in 0.30, but since it's testing only it doesn't matter to consuming users.

@jacobheun jacobheun merged commit c6fd23a into 0.30.x Nov 24, 2020
@jacobheun jacobheun deleted the chore/update-websockets branch November 24, 2020 13:39
@vasco-santos
Copy link
Member Author

it's a breaking change in behavior only, and there is no reason why someone cannot use libp2p-websockets 0.15 with js-libp2p 0.29.x

That is true, but it might break local testing environments of users like injs-libp2p. I would like to just change it to latest once we have the migration guide and this information in there

vasco-santos added a commit that referenced this pull request Dec 10, 2020
* chore: update websockets
vasco-santos added a commit that referenced this pull request Dec 16, 2020
* chore: update websockets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants