Skip to content

fix(tcp): close socket when reset races shutdown #3597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tabcat merged 5 commits into from
Aug 20, 2026
Merged

fix(tcp): close socket when reset races shutdown #3597

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84b8a51
fix(tcp): close socket when reset races shutdown
GrapeBaBa Aug 11, 2026
39da684
Merge branch 'main' into experiment/minimal-reset-shutdown
GrapeBaBa Aug 14, 2026
6a0a3e0
docs(tcp): explain shutdown reset guard
GrapeBaBa Aug 14, 2026
c190c0a
Merge branch 'main' into experiment/minimal-reset-shutdown
GrapeBaBa Aug 19, 2026
2424934
test(tcp): cover reset racing graceful shutdown
tabcat Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/transport-tcp/src/socket-to-conn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,16 @@ class TCPSocketMultiaddrConnection extends AbstractMultiaddrConnection {
}

sendReset (): void {
if (this.socket.writableEnded) {
// socket.end() starts the graceful shutdown path, which uses uv_shutdown().
// resetAndDestroy() calls uv_tcp_close_reset(), which cannot be mixed with
// uv_shutdown(), so use destroy() after writable end has started.
// https://docs.libuv.org/en/v1.x/stream.html#c.uv_shutdown
// https://docs.libuv.org/en/v1.x/tcp.html#c.uv_tcp_close_reset
this.socket.destroy()
return
}

this.socket.resetAndDestroy()
}

Expand Down
Loading