fix: remove while loop for setbit & getbit

[dozyio]

Description

Constant time setbit and getbit in the bloom filter - was hitting performance issues when using a 30mb bloom filter

Notes & open questions

Benchmarks below

Loop 8bits x 171,777,298 ops/sec ±2.70% (89 runs sampled)
Math Ops 8bits x 216,520,449 ops/sec ±6.46% (77 runs sampled)

Loop 64bits x 127,603,004 ops/sec ±3.28% (85 runs sampled)
Math Ops 64bits x 225,485,149 ops/sec ±5.94% (81 runs sampled)

Loop 512bits x 35,893,950 ops/sec ±0.76% (97 runs sampled)
Math Ops 512bits x 223,396,999 ops/sec ±5.05% (79 runs sampled)

Loop 4096bits x 4,824,731 ops/sec ±0.91% (97 runs sampled)
Math Ops 4096bits x 211,234,954 ops/sec ±5.26% (77 runs sampled)

Loop 32768bits x 579,890 ops/sec ±0.40% (100 runs sampled)
Math Ops 32768bits x 206,112,847 ops/sec ±5.97% (74 runs sampled)

Loop 262144bits x 60,922 ops/sec ±0.15% (98 runs sampled)
Math Ops 262144bits x 203,502,874 ops/sec ±6.71% (72 runs sampled)

Loop 2097152bits x 7,626 ops/sec ±0.26% (101 runs sampled)
Math Ops 2097152bits x 210,668,544 ops/sec ±5.40% (76 runs sampled)

Loop 251658240bits x 63.70 ops/sec ±0.18% (68 runs sampled)
Math Ops 251658240bits x 209,501,599 ops/sec ±6.41% (73 runs sampled)

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation if necessary (this includes comments as well)
• I have added tests that prove my fix is effective or that my feature works

[achingbrain]

This looks good, thanks for opening it.

Out of interest, where are you using BloomFilter?

I can only see it used once in the libp2p codebase (for filtering circuit relay servers) - in general I think you'd want to use ScalableCuckooFilter instead as it can grow beyond the initially configured size.

[dozyio]

This looks good, thanks for opening it.

Out of interest, where are you using BloomFilter?

I can only see it used once in the libp2p codebase (for filtering circuit relay servers) - in general I think you'd want to use ScalableCuckooFilter instead as it can grow beyond the initially configured size.

Hey Alex - I'm using it in https://github.com/dozyio/js-ds-crdt to check if keys are deleted from a set - was going to use bloom-filters but saw your issue Callidon/bloom-filters#70 - the one in utils should be fine once this pr is applied

[achingbrain]

Fair enough. This implementation might get removed in the future since we could just use a cuckoo filter for filtering relay servers but hopefully the bloom-filters module will ship it's v4 at some point soon.