feat: extensible peer ids - #2496
Merged
Merged
Conversation
Sometimes a peer will have a non-cryptographic identifier such as a URL. Update the PeerId type to be an interface so we can use arbitrary data to identify other peers, not just cryptographic keys.
5 tasks
SgtPooki
reviewed
Apr 23, 2024
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
maschad
approved these changes
Apr 23, 2024
SgtPooki
approved these changes
Apr 23, 2024
SgtPooki
left a comment
Member
There was a problem hiding this comment.
two minor issues in comments. otherwise looks pretty straightforward.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes a peer will have a non-cryptographic identifier such as a URL.
Update the PeerId type to be an interface so we can use arbitrary data to identify other peers, not just cryptographic keys.
Change checklist