Skip to content

feat: extensible peer ids - #2496

Merged
achingbrain merged 5 commits into
mainfrom
feat/extensible-peer-ids
Apr 24, 2024
Merged

feat: extensible peer ids#2496
achingbrain merged 5 commits into
mainfrom
feat/extensible-peer-ids

Conversation

@achingbrain

Copy link
Copy Markdown
Member

Sometimes a peer will have a non-cryptographic identifier such as a URL.

Update the PeerId type to be an interface so we can use arbitrary data to identify other peers, not just cryptographic keys.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Sometimes a peer will have a non-cryptographic identifier such as
a URL.

Update the PeerId type to be an interface so we can use arbitrary
data to identify other peers, not just cryptographic keys.
@achingbrain
achingbrain requested a review from a team as a code owner April 23, 2024 06:10
Comment thread packages/crypto/src/keys/index.ts Outdated
Comment thread packages/crypto/src/keys/index.ts Outdated
Comment thread packages/crypto/src/keys/index.ts Outdated
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>

@SgtPooki SgtPooki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor issues in comments. otherwise looks pretty straightforward.

Comment thread packages/crypto/src/keys/index.ts
Comment thread packages/interface/src/peer-id/index.ts Outdated
@achingbrain
achingbrain merged commit 0d5d966 into main Apr 24, 2024
@achingbrain
achingbrain deleted the feat/extensible-peer-ids branch April 24, 2024 08:09
@achingbrain achingbrain mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants