Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve libp2p config #46

Closed
daviddias opened this issue Nov 27, 2016 · 4 comments
Closed

Improve libp2p config #46

daviddias opened this issue Nov 27, 2016 · 4 comments
Assignees
@daviddias
Labels
exp/expert Having worked on the specific codebase is important exploration kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up

Comments

@daviddias
Copy link
Member

Right now, it is impossible to signal through the config if we want to use a transport just for dialing and not for listening, in fact, go-ipfs makes the hard decision of disabling any dialing from a transport from where we are not listening.

The issue is that with this design, we have to make something hacky/hard coded to enable the WebSockets transport within libp2p-swarm for dialing in the browser.

https://github.com/libp2p/js-libp2p/blob/master/src/index.js#L97-L102

Ideas:

  • Have a dialer multiaddr addr to signal that no listener should be started, but it should be considered to dial anyway
  • Have a more config option within the config.json that informs swarm to do that.
@daviddias daviddias added exp/expert Having worked on the specific codebase is important exploration kind/enhancement A net-new feature or improvement to an existing feature libp2p-backlog labels Nov 27, 2016
@daviddias daviddias added the status/deferred Conscious decision to pause or backlog label Dec 5, 2016
@daviddias daviddias added status/ready Ready to be worked and removed status/deferred Conscious decision to pause or backlog labels Feb 5, 2018
@daviddias daviddias mentioned this issue Feb 5, 2018
Closed
13 tasks
@daviddias daviddias added the P2 Medium: Good to have, but can wait until someone steps up label Feb 5, 2018
@daviddias daviddias mentioned this issue Feb 20, 2018
Merged
3 tasks
@daviddias daviddias self-assigned this Feb 20, 2018
@daviddias
Copy link
Member Author

Please review proposal here #166

@vasco-santos vasco-santos mentioned this issue Jun 28, 2018
Merged
@jacobheun
Copy link
Contributor

With #166 merged I think we could add transport configuration for something like isDialer and then push all dialer only transports into the switch transports after startup. This could be enabled by default, as that is already a set expectation with web sockets.

@daviddias
Copy link
Member Author

@jacobheun related, see #201

@daviddias
Copy link
Member Author

DONE \o/ :D

@ghost ghost removed the status/ready Ready to be worked label Jul 5, 2018
@malisetti malisetti mentioned this issue Jan 3, 2019
Closed
jacobheun pushed a commit to jacobheun/js-libp2p that referenced this issue Jul 29, 2019
@daviddias
Merge pull request libp2p#46 from diasdavid/feat/improve-identify
b453bd4 
Freeze handling conns till identify is finished on the incomming multiplexed streams
vasco-santos pushed a commit that referenced this issue Apr 29, 2020
@dependabot-preview
chore(deps-dev): bump datastore-fs from 0.9.1 to 1.0.0 (#46)
9e96dbc 
Bumps [datastore-fs](https://github.com/ipfs/js-datastore-fs) from 0.9.1 to 1.0.0.
- [Release notes](https://github.com/ipfs/js-datastore-fs/releases)
- [Changelog](https://github.com/ipfs/js-datastore-fs/blob/master/CHANGELOG.md)
- [Commits](ipfs/js-datastore-fs@v0.9.1...v1.0.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@chafey chafey mentioned this issue Sep 30, 2020
Closed
@snyk-bot snyk-bot mentioned this issue Jan 21, 2022
Open
@snyk-bot snyk-bot mentioned this issue Mar 21, 2022
Open
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@web3-bot
sync: update CI config files (libp2p#46)
fed1b5c
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@dependabot @achingbrain
deps: bump aegir from 37.12.1 to 38.1.0 (libp2p#46)
ba54f6a 
* deps: bump aegir from 37.12.1 to 38.1.0

Bumps [aegir](https://github.com/ipfs/aegir) from 37.12.1 to 38.1.0.
- [Release notes](https://github.com/ipfs/aegir/releases)
- [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md)
- [Commits](ipfs/aegir@v37.12.1...v38.1.0)

---
updated-dependencies:
- dependency-name: aegir
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix: add return types to methods and remove pointless awaits

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: achingbrain <[email protected]>
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
6540b5d 
## [@libp2p/peer-id-v2.0.1](https://github.com/libp2p/js-libp2p-peer-id/compare/@libp2p/peer-id-v2.0.0...@libp2p/peer-id-v2.0.1) (2023-01-18)

### Trivial Changes

* replace err-code with CodeError ([libp2p#45](libp2p/js-libp2p-peer-id#45)) ([06e39f0](libp2p/js-libp2p-peer-id@06e39f0)), closes [libp2p#1269](https://github.com/libp2p/js-libp2p-peer-id/issues/1269)

### Dependencies

* bump aegir from 37.12.1 to 38.1.0 ([libp2p#46](libp2p/js-libp2p-peer-id#46)) ([ba54f6a](libp2p/js-libp2p-peer-id@ba54f6a))
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
3044cdd 
## [@libp2p/peer-id-factory-v2.0.1](https://github.com/libp2p/js-libp2p-peer-id/compare/@libp2p/peer-id-factory-v2.0.0...@libp2p/peer-id-factory-v2.0.1) (2023-01-18)

### Dependencies

* bump aegir from 37.12.1 to 38.1.0 ([libp2p#46](libp2p/js-libp2p-peer-id#46)) ([ba54f6a](libp2p/js-libp2p-peer-id@ba54f6a))
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@web3-bot
sync: update CI config files (libp2p#46)
299591e
achingbrain pushed a commit that referenced this issue Jun 27, 2023
@daviddias
Merge pull request #46 from libp2p/fix/race
fe14d26 
fix/race
@tabcat tabcat mentioned this issue Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daviddias daviddias

Labels
exp/expert Having worked on the specific codebase is important exploration kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobheun @daviddias