fix: not create stream if it already exists (#48)

libp2p · Jun 15, 2020 · f3b06d9 · f3b06d9
1 parent d478ed0
commit f3b06d9
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/src/index.js b/src/index.js
@@ -196,6 +196,10 @@ class PubsubBaseProtocol extends EventEmitter {
       protocols: this.multicodecs
     }))
 
+    if (peer.isConnected) {
+      return
+    }
+
     try {
       const { stream } = await conn.newStream(this.multicodecs)
       peer.attachConnection(stream)

diff --git a/test/pubsub.spec.js b/test/pubsub.spec.js
@@ -189,6 +189,29 @@ describe('pubsub base protocol', () => {
       expect(pubsubB.peers.size).to.be.eql(1)
     })
 
+    it('should not create a new stream if onConnect is called twice', async () => {
+      const onConnectA = registrarRecordA[protocol].onConnect
+      const handlerB = registrarRecordB[protocol].handler
+
+      // Notice peers of connection
+      const [c0, c1] = ConnectionPair()
+
+      const spyNewStream = sinon.spy(c0, 'newStream')
+
+      await onConnectA(peerIdB, c0)
+      await handlerB({
+        protocol,
+        stream: c1.stream,
+        connection: {
+          remotePeer: peerIdA
+        }
+      })
+      expect(spyNewStream).to.have.property('callCount', 1)
+
+      await onConnectA(peerIdB, c0)
+      expect(spyNewStream).to.have.property('callCount', 1)
+    })
+
     it('should handle newStream errors in onConnect', async () => {
       const onConnectA = registrarRecordA[protocol].onConnect
       const handlerB = registrarRecordB[protocol].handler