Skip to content
This repository was archived by the owner on Jul 21, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions API.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# API

* [addressSort.publicAddressesFirst(addresses)](#addresssortpublicaddressesfirstaddresses)
* [Parameters](#parameters)
* [Returns](#returns)
* [Example](#example)
* [arrayEquals(a, b)](#arrayequalsa-b)
* [Parameters](#parameters)
* [Returns](#returns)
Expand All @@ -21,6 +25,42 @@
* [Returns](#returns-4)
* [Example](#example-4)

## addressSort.publicAddressesFirst(addresses)

Sort given addresses by putting public addresses first. In case of equality, a certified address will come first.

### Parameters

| Name | Type | Description |
|------|------|-------------|
| addresses | `Array<Address>` | Array of AddressBook addresses |

### Returns

| Type | Description |
|------|-------------|
| `Array<Address>` | returns array of sorted addresses |

### Example

```js
const multiaddr = require('multiaddr')
const { publicAddressesFirst } = require('libp2p-utils/src/address-sort')

const addresses = [
{
multiaddr: multiaddr('/ip4/127.0.0.1/tcp/4000'),
isCertified: false
},
{
multiaddr: multiaddr('/ip4/30.0.0.1/tcp/4000'),
isCertified: false
}
]

const sortedAddresses = publicAddressesFirst(addresses)
```

## arrayEquals(a, b)

Verify if two arrays of non primitive types with the "equals" function are equal.
Expand Down
44 changes: 44 additions & 0 deletions src/address-sort.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
'use strict'

const isPrivate = require('./multiaddr/is-private')

/**
* Compare function for array.sort().
* This sort aims to move the private adresses to the end of the array.
* In case of equality, a certified address will come first.
*
* @param {Address} a
* @param {Address} b
* @returns {number}
*/
function addressesPublicFirstCompareFunction (a, b) {
const isAPrivate = isPrivate(a.multiaddr)
const isBPrivate = isPrivate(b.multiaddr)

if (isAPrivate && !isBPrivate) {
return 1
} else if (!isAPrivate && isBPrivate) {
return -1
}
// Check certified?
if (a.isCertified && !b.isCertified) {
return -1
} else if (!a.isCertified && b.isCertified) {
return 1
}

return 0
}

/**
* Sort given addresses by putting public addresses first.
* In case of equality, a certified address will come first.
*
* @param {Array<Address>} addresses
* @returns {Array<Address>}
*/
function publicAddressesFirst (addresses) {
return [...addresses].sort(addressesPublicFirstCompareFunction)
}

module.exports.publicAddressesFirst = publicAddressesFirst
53 changes: 53 additions & 0 deletions test/address-sort.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
'use strict'
/* eslint-env mocha */

const { expect } = require('aegir/utils/chai')
const multiaddr = require('multiaddr')

const { publicAddressesFirst } = require('../src/address-sort')

describe('address-sort', () => {
it('should sort public addresses first', () => {
const addresses = [
{
multiaddr: multiaddr('/ip4/127.0.0.1/tcp/4000'),
isCertified: false
},
{
multiaddr: multiaddr('/ip4/30.0.0.1/tcp/4000'),
isCertified: false
},
{
multiaddr: multiaddr('/ip4/31.0.0.1/tcp/4000'),
isCertified: false
}
]

const sortedAddresses = publicAddressesFirst(addresses)
expect(sortedAddresses[0].multiaddr.equals(multiaddr('/ip4/30.0.0.1/tcp/4000'))).to.eql(true)
expect(sortedAddresses[1].multiaddr.equals(multiaddr('/ip4/31.0.0.1/tcp/4000'))).to.eql(true)
expect(sortedAddresses[2].multiaddr.equals(multiaddr('/ip4/127.0.0.1/tcp/4000'))).to.eql(true)
})

it('should sort public certified addresses first', () => {
const addresses = [
{
multiaddr: multiaddr('/ip4/127.0.0.1/tcp/4000'),
isCertified: false
},
{
multiaddr: multiaddr('/ip4/30.0.0.1/tcp/4000'),
isCertified: false
},
{
multiaddr: multiaddr('/ip4/31.0.0.1/tcp/4000'),
isCertified: true
}
]

const sortedAddresses = publicAddressesFirst(addresses)
expect(sortedAddresses[0].multiaddr.equals(multiaddr('/ip4/31.0.0.1/tcp/4000'))).to.eql(true)
expect(sortedAddresses[1].multiaddr.equals(multiaddr('/ip4/30.0.0.1/tcp/4000'))).to.eql(true)
expect(sortedAddresses[2].multiaddr.equals(multiaddr('/ip4/127.0.0.1/tcp/4000'))).to.eql(true)
})
})