This repository was archived by the owner on Jul 21, 2023. It is now read-only.
fix: replace node buffers with uint8arrays #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: - All use of node Buffers has been replaced with Uint8Arrays
jacobheun
reviewed
Aug 10, 2020
src/coder/encode.js
Outdated
| class Encoder { | ||
| constructor () { | ||
| this._pool = Buffer.allocUnsafe(POOL_SIZE) | ||
| this._pool = new Uint8Array(POOL_SIZE) |
Contributor
There was a problem hiding this comment.
We should run the mega stress tests to verify the performance here is stable. https://github.com/libp2p/js-libp2p-interfaces/blob/master/src/stream-muxer/tests/mega-stress-test.js#L7
jacobheun
reviewed
Aug 10, 2020
| varint.encode(msg.data ? msg.data.length : 0, pool, offset) | ||
| offset += varint.encode.bytes | ||
|
|
||
| const header = pool.slice(this._poolOffset, offset) |
Contributor
There was a problem hiding this comment.
We'll need to check where we're doing slices and look at using subarray instead, https://nodejs.org/api/buffer.html#buffer_buf_subarray_start_end. slice will cause a clone on TypedArrays, whereas with Buffer it will reference the same memory.
Contributor
There was a problem hiding this comment.
This is now using subarray for the browser version.
64 tasks
Contributor
|
I created a browser specific file for encode to use Uint8Array, which will let us keep allocUnsafe for Node.js streams. |
jacobheun
approved these changes
Aug 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer lists are still used internally but any Buffers created by this module are now Uint8Arrays.
BREAKING CHANGE: