This repository was archived by the owner on Jun 26, 2023. It is now read-only.
Conversation
vasco-santos
approved these changes
Dec 2, 2020
Member
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
Thanks, this looks good!
I am merging it into the other PR to test it against libp2p and fix the connection status + pubsub stream in there
| 'use strict' | ||
|
|
||
| module.exports = { | ||
| const STATUS = { |
Member
There was a problem hiding this comment.
This seems to be causing issues integrating with libp2p PR
Member
There was a problem hiding this comment.
"Property 'OPEN' does not exist on type 'typeof import("/Users/vsantos/work/pl/gh/libp2p/js-libp2p-interfaces/dist/src/connection/status")'"
Using:
const ConnectionStatus = require('libp2p-interfaces/src/connection/status')
ConnectionStatus.OPEN| try { | ||
| const { stream, protocol } = await conn.newStream(this.multicodecs) | ||
| const peer = this._addPeer(peerId, protocol) | ||
| // @ts-ignore MuxedStream is not DuplexIterableStream |
Member
There was a problem hiding this comment.
I will address this after merging. This should really be using the muxedStream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I end up fixing bunch of issues that were appearing in #74 when type-checking with new aegir.