-
Notifications
You must be signed in to change notification settings - Fork 15
package.json - fix main reference #6
Conversation
| "version": "0.3.0", | ||
| "description": "libp2p-floodsub, also known as pubsub-flood or just dumbsub, this implementation of pubsub focused on delivering an API for Publish/Subscribe, but with no CastTree Forming (it just floods the network).", | ||
| "main": "lib/core/index.js", | ||
| "main": "src/core/index.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be "main": "src/index.js".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be "lib/index.js"
haadcode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure the path is correct. Otherwise this LGTM and is needed to get the module working.
|
Actually, take that back. pointing to |
|
yep, it should be lib, that is what gets published. See https://github.com/ipfs/community/blob/master/js-project-guidelines.md |
|
oh! build-and-publish. gotcha. I think `"main": "dist/index.js" would be more clear, but may be difficult to change that at this point. |
|
@kumavis it's not ideal, but we have a plan of moving to |
|
@dignifiedquire thanks! just got off a call with @diasdavid and he explained the situation in depth |
No description provided.