fix: limit concurrent HTTP requests#16
Merged
Merged
Conversation
All HTTP requests made by this module are sent to the same delegate host. Browsers throttle the number of concurrent requests per hostname, right now it is 6 per host, which suffocates the use of delegate and blocking it from being used for preload or delegated peer routing. This change introduces task queues that limit the number of concurrent requests, making it safe to run in browser context. Optimizations: - preload calls via `refs` are known to take time, so we limit them to max two at a time - swarm.connect was the main offender (causing multiple requests to delegate), we now check if connection is already present and cache result for 1 minute removing most of redundant http requests - hostname of default delegate is changed Context: libp2p#12 Closes libp2p#12 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
force-pushed
the
fix/http-throttling
branch
from
837db29 to
735c70f
Compare
This removes all code that caused swarm connect calls from delegate to self. It was not needed: delegate is one of bootstrap nodes, so we are always connected to it. libp2p#12 (comment) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
We no longer need those (removed calls to swarm.connect) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
jacobheun
approved these changes
Jul 24, 2019
Contributor
jacobheun
left a comment
jacobheun
left a comment
There was a problem hiding this comment.
This change looks good and should drastically cut down on requests
Contributor
|
Released in 0.3.1 |
lidel
added a commit
to lidel/js-libp2p-delegated-content-routing
that referenced
this pull request
Jul 26, 2019
This is a backport of the fix from libp2p#16 that works with 0.2.x License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
jacobheun
pushed a commit
that referenced
this pull request
Jul 29, 2019
* fix: limit concurrent HTTP requests This is a backport of the fix from #16 that works with 0.2.x License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org> * refactor: simplify callbacks License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All HTTP requests made by this module are sent to the same delegate
host. Browsers throttle the number of concurrent requests per hostname.
Right now the limit is 6 per host, which suffocates connection pool to the delegate (#12)
blocking it from being used for preload in js-ipfs or delegated peer routing.
This PR:
Additional optimizations:
refsare known to take time,that is why we use separate queue to limit them to max two at a time
swarm connectwas the main offender (causing multiple requests to delegate)we removed it entirely, as agreed in Request flood in web browser #12 (comment)
Context: #12
Closes #12