This repository was archived by the owner on Jul 21, 2023. It is now read-only.
Fix Ed25519 key ID generation (fixes ipfs/js-ipfs#3591)#185
Closed
nadimkobeissi wants to merge 2 commits intolibp2p:masterfrom
nadimkobeissi:master
Closed
Fix Ed25519 key ID generation (fixes ipfs/js-ipfs#3591)#185nadimkobeissi wants to merge 2 commits intolibp2p:masterfrom nadimkobeissi:master
nadimkobeissi wants to merge 2 commits intolibp2p:masterfrom
nadimkobeissi:master
Conversation
As discussed here: ipfs/js-ipfs#3591
|
Linter is angry |
Contributor
Author
@TheDiscordian Fixed in 22be691. |
Contributor
|
Thanks for the PR! I've merged this via bc33769 to include a fix for the existing tests that weren't catching this. The output is now more strictly checked. I'll release a patch for this shortly. |
jacobheun
pushed a commit
that referenced
this pull request
Mar 17, 2021
* Fix Ed25519 PeerID generation This commit pushes further fixes to the generation of Ed25519 peer IDs, building upon the discussion in ipfs/js-ipfs#3591 and the subsequent pull request #185. The purpose of this new pull request is to harmonize the encoding of PeerIDs for Ed25519 keys such that the same new format is used everywhere: peer IDs when assigned upon key generation, peer IDs when shown via key listing, as well as the peer IDs displayed as IPNS names when the key is used as the basis for an IPNS record. Concretely, this changes the peer ID representation of Ed25519 keys from the `Qm...` format to the newer `1...` format. The accompanying test has been modified accordingly. * Satisfy linter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This commit proposes what appears to be a working and sane fix for the issue documented at ipfs/js-ipfs#3591.
I'd appreciate expert review and subsequent integration into the codebase.