This repository was archived by the owner on Jul 21, 2023. It is now read-only.
fix: better error for missing web crypto#157
Merged
dignifiedquire merged 2 commits intomasterfrom Aug 13, 2019
Merged
Conversation
alanshaw
requested review from
achingbrain,
daviddias,
hugomrdias,
jacobheun,
lidel and
vasco-santos
dirkmc
approved these changes
Jul 17, 2019
Contributor
dirkmc
left a comment
dirkmc
left a comment
There was a problem hiding this comment.
We get this issue coming up constantly, I think this will save everyone a lot of time 👍 🎉
mkg20001
approved these changes
Jul 17, 2019
achingbrain
approved these changes
Jul 18, 2019
lidel
approved these changes
Jul 19, 2019
This PR simply detects missing web crypto and throws an error with an appropriate message. This is a stepping stone that will help users understand the problem until we have time to do a refactor of this module and of all the modules that use it to enable optionally passing your own crypto implementation. refs #149 refs #150 refs #105 refs ipfs/js-ipfs#2153 refs ipfs/js-ipfs#2017 License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
jacobheun
force-pushed
the
fix/better-err-missing-webcrypto
branch
from
03e9260 to
afe94de
Compare
Contributor
|
I rebased this with the latest master so we can include this and the error code update in the next release. |
Member
Author
|
@dignifiedquire 🙏 can we get a merge and release? |
dignifiedquire
approved these changes
Aug 13, 2019
Member
Author
|
❤️ thanks @dignifiedquire |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply detects missing web crypto and throws an error with an appropriate message.
This is a stepping stone that will help users understand the problem until we have time to do a refactor of this module and of all the modules that use it to enable optionally passing your own crypto implementation.
refs #149
refs #150
refs #105
refs ipfs/js-ipfs#2153
refs ipfs/js-ipfs#2017