This repository has been archived by the owner on May 26, 2022. It is now read-only.
modernize request handling #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this was written before request hijacking was a thing. We no longer need to hold the `ServeHTTP` function open.
ghost
assigned 
vyzo
approved these changes
Apr 4, 2019
anacrolix
approved these changes
Apr 4, 2019
| }() | ||
| go func() { | ||
| _ = c.Close() | ||
| }() |
There was a problem hiding this comment.
Making linters happy and making it clear that we're explicitly ignoring the errors. I can't actually check the errors because this is a stress-test and both of these functions may or may not error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this was written before request hijacking was a thing. We no longer need to hold the
ServeHTTPfunction open.