add test for deadlines

[vyzo]

seems to be broken...

[Stebalien]

Deadlock?

[vyzo]

Not sure what it is, the AwaitEOF goroutines are stuck in waitForData apparently without a deadline.

[Stebalien]

Can we figure out what's actually happening? The code looks correct.

[vyzo]

I agree that the code looks correct, so this is a little mystifying...

[vyzo]

Oh I think I know what's happening: we set the handshake deadline in the stream, which can then time out, killing the Close sendMsg!
It's a bug in the relay code, the deadline needs to be reset before attempting to handleError.

[vyzo]

No wait, close is not sent with the deadline.

[vyzo]

ah, it is the bug indeed in the error message is never sent due to the deadline being exceeded, which results in the initiating peer never responding.

[vyzo]

no wait, the deadline is on the other side of the hop.

[vyzo]

trying to debug the issue: restored deadline setting checks and added error logs when not setting the read deadlines.

[vyzo]

It's full of these:

May 23 10:20:59 relays-sjc-01 relay.sh[18486]: 10:20:59.374 ERROR      mplex: not setting deadline; stream is closed stream.go:255

and these:

May 23 10:20:59 relays-sjc-01 relay.sh[18486]: 10:20:59.380 ERROR      mplex: not setting read deadline; remote has closed stream.go:262

[vyzo]

so the stream is already marked closed, failing to set the deadline in AwaitEOF.

[vyzo]

the more pertinent question is why waitForData doesn't return immediately, which would be the bug.

[vyzo]

I don't understand how this is happening, we always close either reset or dataIn when we set closedRemote = true...

[vyzo]

Added assertion in c2ceeb7 to test for the impossible condition.

[vyzo]

it's not triggering, so that was possibly a red herring...

[vyzo]

I can't seem to reproduce the issue; I don't know what happened.

At any rate, this adds a test for deadlines that was missing.