reduce the packet count #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
force-pushed
the
fix/fewer-packets
branch
2 times, most recently
from
25b7b5f
to
17259f2
Compare
|
This should help a bit but we should still buffer the stream open headers until we need to send data. |
|
I've also fixed #7 (technically) by just killing the connection on partial writes. |
raulk
added
the
kind/enhancement
That way, we don't send a bunch of tiny packets. The extra copy is nothing compared to that.
fixes #7 (not the best way but it works)
Stebalien
force-pushed
the
fix/fewer-packets
branch
from
fd3b3b3
to
cd7c98f
Compare
vyzo
approved these changes
Oct 12, 2018
| if err := mp.con.SetWriteDeadline(time.Time{}); err != nil { | ||
| return err | ||
| // only return this error if we don't *already* have an error from the write. | ||
| if err2 := mp.con.SetWriteDeadline(time.Time{}); err == nil && err2 != nil { |
There was a problem hiding this comment.
so we were eating the original error here? nice catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send header in the same message as the body.