Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UDP listen on a Unspecified Address and Dial from the Unspecified Address #561

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Fix UDP listen on a Unspecified Address and Dial from the Unspecified Address #561

merged 1 commit into from
Mar 15, 2019

Conversation

lnykww
Copy link
Contributor

@lnykww lnykww commented Mar 14, 2019

LocalMultiaddr May return the Unspecified Address, if so, we need to
check if we listen on the Unspecified address and they were equal.

@lnykww
Fix UDP listen on a Unspecified Address and Dial from the Unspecified…
5da711d 
… Address

LocalMultiaddr May return the Unspecified Address, if so, we need to
check if we listen on the Unspecified address and they were equal.
Stebalien
Stebalien approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Stebalien Stebalien merged commit 0e4b173 into libp2p:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lnykww @Stebalien